🐛 Allow type_
kwarg in sa_column_kwargs
#158
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #156 @phi-friday wanted to pass
sa_column_kwargs={"type_": Unicode}
to aField
to set the column tonvarchar
, doing this causes an exception:sa_type
is passed by get_column_from_field as a positional argument, so passing it through at a kwarg leads to this exception.PR checks if
type_
is in the kwargs, and if it is it pops it from the kwargs and setssa_type
to its value.Also added a test for this case, @tiangolo is issue-related tests in a separate directory a thing you like? It's not done in FastAPI or here, so if not I'll move it.
Edit: whoops, forgot the
sa_column
argument existed, given that this seems kind of pointless 🤔