Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

favicon size #359

Open
BOR-LAND opened this issue Nov 22, 2024 · 1 comment
Open

favicon size #359

BOR-LAND opened this issue Nov 22, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@BOR-LAND
Copy link

At https://www.youtube.com/ uses instead of favicon:
https://www.youtube.com/s/desktop/208496d9/img/logos/favicon_144x144.png (144px × 144px)
although there is:
https://www.youtube.com/s/desktop/208496d9/img/logos/favicon.ico (16px × 16px)
загружено


At https://hdrezka.ag/ uses instead of favicon:
https://hdrezka.ag/apple-touch-icon-144.png (144px × 144px)
although there is:
https://static.hdrezka.ac/templates/hdrezka/images/favicon.ico (48px × 48px)
https://static.hdrezka.ac/templates/hdrezka/images/favicon-32x32.png (32px × 32px)
https://static.hdrezka.ac/templates/hdrezka/images/favicon-16x16.png (16px × 16px)
image


At https://nsaneforums.com/nsane.down/ uses instead of favicon:
https://nsaneforums.com/uploads/monthly_2021_08/android-chrome-512x512.png (512 × 512px)
although there is:
https://nsaneforums.com/uploads/monthly_2021_08/android-chrome-36x36.png (36 × 36px)
this causes a blue dot to be displayed instead of the favicon:
image


GroupSpeedDial uses very large images for favicon.
Need the ability to change favicon, or set a maximum size for favicon to avoid problems.

Device info:

  • operating system: Windows 10
  • Browser and version: Firefox 132.0.2
  • GroupSpeedDial version: v26.0
@BOR-LAND BOR-LAND added the bug Something isn't working label Nov 22, 2024
@Juraj-Masiar
Copy link
Member

Thanks for the report!

The code for favicon download is pretty old now and it does look for the biggest favicon there is.
But situation is not that simple, for example:

  • in some places, favicons are 24px large (in list layout / search / multi-page dials)
  • if you increase page zoom or font size in Options, the icon size needs to be bigger too
  • if you have a high resolution screen, for example with 200% scaling (like many modern 4K notebooks), you need double resolution favicon, so ideally at least 48px
  • real world is a messy place, some pages gives you only 16px ".ico" or 512px huge PNG, for example this biggest Czecho-Slovak e-shop Alza:
    image

But I see the issue, some pages will indeed serve a different picture which is not suitable as favicon.
Although the example with 512px image you've posted is clearly a website issue :).

I'll upgrade the code so that it will prioritize 48px/32px icons if there is one.
There is also plan to add "customize favicon" option, which will allow you to fix specific favicons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants