Skip to content

Commit

Permalink
Merge pull request #423 from fasenderos/node-test-runner
Browse files Browse the repository at this point in the history
test: replace tap with the built-in node test runner
  • Loading branch information
fasenderos authored Aug 5, 2024
2 parents bb94ef9 + f81ddd8 commit 8ba7ba2
Show file tree
Hide file tree
Showing 18 changed files with 1,871 additions and 7,681 deletions.
6 changes: 3 additions & 3 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
build:
working_directory: ~/hft-limit-order-book
docker:
- image: cimg/node:lts
- image: cimg/node:22.5
steps:
- checkout
- *restore-cache
Expand All @@ -33,7 +33,7 @@ jobs:
test:
working_directory: ~/hft-limit-order-book
docker:
- image: cimg/node:lts
- image: cimg/node:22.5
steps:
- checkout
- *restore-cache
Expand All @@ -42,7 +42,7 @@ jobs:
name: Unit tests
command: npm run test:cov
- codecov/upload:
file: './.tap/report/lcov.info'
file: 'lcov.info'

workflows:
version: 2
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ jobs:
- name: Setup .npmrc file to publish to npm
uses: actions/setup-node@b39b52d1213e96004bfcb1c61a8a6fa8ab84f3e8 # v4.0.1
with:
node-version: '18.x'
node-version: '20.x'
registry-url: 'https://registry.npmjs.org'
- name: Install modules
run: npm install
Expand All @@ -36,7 +36,7 @@ jobs:
- name: Setup .npmrc file to publish to GitHub Packages
uses: actions/setup-node@b39b52d1213e96004bfcb1c61a8a6fa8ab84f3e8 # v4.0.1
with:
node-version: '18.x'
node-version: '20.x'
registry-url: 'https://npm.pkg.github.com'
scope: '@fasenderos'
- run: npm run addscope
Expand Down
9 changes: 3 additions & 6 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,13 +26,10 @@ on:

jobs:
test:
runs-on: ${{ matrix.os }}
runs-on: ubuntu-latest
strategy:
matrix:
os:
- ubuntu-latest
- windows-latest
node: [18.x, 20.x]
node: [20.x, 22.x]

steps:
- uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
Expand All @@ -43,4 +40,4 @@ jobs:
- name: Install modules
run: npm install
- name: Run tests
run: npm test
run: npm run test:ci
4 changes: 2 additions & 2 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@ pids
*.seed
*.pid.lock

# Report and coverage generated by tap
.tap
# Report and coverage generated by node test runner
lcov.info

# Grunt intermediate storage (https://gruntjs.com/creating-plugins#storing-task-files)
.grunt
Expand Down
2 changes: 1 addition & 1 deletion .husky/pre-commit
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
npm run lint
npm run test
npm run test:ci
Loading

0 comments on commit 8ba7ba2

Please sign in to comment.