Skip to content

Commit

Permalink
The backfill check should take more precedence when determining wheth…
Browse files Browse the repository at this point in the history
…er to reset data (#1846)
  • Loading branch information
ypc-faros authored Dec 9, 2024
1 parent b26b5a8 commit 3de2ec3
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions destinations/airbyte-faros-destination/src/destination.ts
Original file line number Diff line number Diff line change
Expand Up @@ -997,6 +997,12 @@ export class FarosDestination extends AirbyteDestination<DestinationConfig> {
isFarosSource,
sourceSucceeded,
} = syncInfo;
if (isBackfillSync) {
this.logger.info(
'Running a backfill sync. Skipping reset of non-incremental models.'
);
return false;
}
if (streamStatusReceived) {
if (syncErrors.dst.length) {
this.logger.warn(
Expand Down Expand Up @@ -1026,12 +1032,6 @@ export class FarosDestination extends AirbyteDestination<DestinationConfig> {
this.logger.info('Running a reset sync. Resetting all models.');
return true;
}
if (isBackfillSync) {
this.logger.info(
'Running a backfill sync. Skipping reset of non-incremental models.'
);
return false;
}
if (sourceSucceeded) {
this.logger.info('Source succeeded. Resetting non-incremental models.');
return true;
Expand Down

0 comments on commit 3de2ec3

Please sign in to comment.