Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(compiler): use rust to write resources in parallel #2051

Merged
merged 6 commits into from
Feb 8, 2025

Conversation

fu050409
Copy link
Member

@fu050409 fu050409 commented Jan 9, 2025

Description:

BREAKING CHANGE:

Related issue (if exists):

Copy link

changeset-bot bot commented Jan 9, 2025

⚠️ No Changeset found

Latest commit: 2af12a3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR
Some errors occurred when validating the changesets config:
The package or glob expression "farm-docs" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.

@fu050409 fu050409 requested review from ErKeLost and wre232114 January 9, 2025 05:57
@ErKeLost
Copy link
Member

ErKeLost commented Feb 8, 2025

write_resource_to_disk should consider putting the logic of generating the dist directory and the logic of the public directory into rust. I will consider this in the future. I will first incorporate this pr into v2.

@ErKeLost
Copy link
Member

ErKeLost commented Feb 8, 2025

It seems that it would be better if we were all doing concurrency.

@ErKeLost ErKeLost merged commit 60a1def into v2-dev Feb 8, 2025
36 checks passed
@ErKeLost ErKeLost deleted the feat/rust-write-resource branch February 8, 2025 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants