helmupdater: ignore versions it can't parse as semver

farcaller · Feb 21, 2024 · a1e6662 · a1e6662
1 parent b467a43
commit a1e6662
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 3 deletions.
diff --git a/charts/rook-release/rook-ceph-cluster/default.nix b/charts/rook-release/rook-ceph-cluster/default.nix
@@ -3,4 +3,5 @@
   chart = "rook-ceph-cluster";
   version = "1.13.4";
   chartHash = "sha256-Hnpp9dE1eHl841Wef6Jfx1Zm2X58yUL5OvhLPg2h7Zk=";
+  bogusVersion = true;
 }
diff --git a/charts/rook-release/rook-ceph/default.nix b/charts/rook-release/rook-ceph/default.nix
@@ -3,4 +3,5 @@
   chart = "rook-ceph";
   version = "1.13.4";
   chartHash = "sha256-kSLZ22AKeVfgHpaO7yilNip2WVnsgcv1Ec+j940uubM=";
+  bogusVersion = true;
 }
diff --git a/helmupdater/__init__.py b/helmupdater/__init__.py
@@ -89,9 +89,12 @@ def update_one_chart(
         bogus_version_fixed = True
       if len(version_str.split('-')) != 1:
         continue
-      version = VersionInfo.parse(version_str)
-      if version > remote_version:
-        remote_version = version
+      try:
+        version = VersionInfo.parse(version_str)
+        if version > remote_version:
+          remote_version = version
+      except ValueError:
+        print(f"skipping version `{version_str}` for chart {chart_name}") 
 
     if remote_version <= my_version:
       return