Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set base href in head #70

Merged
merged 3 commits into from
Jul 16, 2024
Merged

Set base href in head #70

merged 3 commits into from
Jul 16, 2024

Conversation

tonyklapatch
Copy link
Contributor

@tonyklapatch tonyklapatch commented Jul 11, 2024 •
edited
Loading

Set base href to the /best-cigars-guide/ subfolder for relative image asset paths

Fix #69

Test URLs:

@tonyklapatch tonyklapatch linked an issue Jul 11, 2024 that may be closed by this pull request
Hero image 404 #69
Closed
@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Jul 11, 2024 •
edited
Loading

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Jul 11, 2024 •
edited
Loading

Page Scores Audits Google
/best-cigars-guide PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@aem-code-sync aem-code-sync bot temporarily deployed to 69-hero-image-404 July 11, 2024 20:53 Inactive
codecodeio
codecodeio approved these changes Jul 15, 2024
View reviewed changes
Copy link
Contributor

@codecodeio codecodeio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice solution. We should implement this on CFB.

bdeffleyfamous
bdeffleyfamous approved these changes Jul 16, 2024
View reviewed changes
Copy link
Contributor

@bdeffleyfamous bdeffleyfamous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@bdeffleyfamous bdeffleyfamous merged commit 32a24c1 into main Jul 16, 2024
2 checks passed
@bdeffleyfamous bdeffleyfamous deleted the 69-hero-image-404 branch July 16, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codecodeio codecodeio codecodeio approved these changes

@bdeffleyfamous bdeffleyfamous bdeffleyfamous approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hero image 404
3 participants
@tonyklapatch @codecodeio @bdeffleyfamous