Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pkg/driverbuilder): fix amazonlinux2023 support. #354

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

FedeDP
Copy link
Contributor

@FedeDP FedeDP commented Sep 3, 2024

What type of PR is this?

/kind bug

Any specific area of the project related to this PR?

/area pkg

What this PR does / why we need it:

Fixes support for amazonlinux2023; also, removes memleak (defer used within a loop).

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

fix(pkg/driverbuilder): fix amazonlinux2023 support.

Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
@poiana poiana added kind/bug Something isn't working dco-signoff: yes area/pkg labels Sep 3, 2024
@FedeDP
Copy link
Contributor Author

FedeDP commented Sep 3, 2024

/cc @LucaGuerra

@poiana
Copy link

poiana commented Sep 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, LucaGuerra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 126a99b into master Sep 3, 2024
7 checks passed
@poiana poiana deleted the fix/al2023_support branch September 3, 2024 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants