Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update(examples): update the grpc unix socket name #69

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

jgornowich
Copy link

@jgornowich jgornowich commented Jan 22, 2024

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area api

/area client

/area tests

/area examples

What this PR does / why we need it:

Which issue(s) this PR fixes:

The default grpc unix socket path was changed in 0.33.0 from /var/run/falco.sock to /run/falco/falco.sock and there were still some stale references to the old socket name.

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: John Gornowich <john.gornowich@progeny.net>
@poiana
Copy link

poiana commented Jan 22, 2024

Welcome @jgornowich! It looks like this is your first PR to falcosecurity/client-go 🎉

Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thank you!

@poiana
Copy link

poiana commented Jan 22, 2024

LGTM label has been added.

Git tree hash: 0d5cd912726bacf1e98dc8d08a2182e41bf189a6

@poiana
Copy link

poiana commented Jan 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jgornowich, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 526d6dc into falcosecurity:master Jan 22, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants