Skip to content

Remove old py versions #440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 38 commits into from
May 7, 2025
Merged

Remove old py versions #440

merged 38 commits into from
May 7, 2025

Conversation

cdorsman
Copy link
Contributor

@cdorsman cdorsman commented May 3, 2025

  • Github Actions was checking with latest version of Python , which is 3.13. I changed this to Python 3.12
  • Removed old versions (2, 2.7, 3.6, 3.7, 3.8) in the following files
    python-patterns/blob/master/setup.cfg
    python-patterns/blob/master/setup.py
    python-patterns/blob/master/.travis.yml
    python-patterns/blob/master/lint.sh
    python-patterns/blob/master/tox.ini

The errors from the workflow are now caused by genuine formatting bugs and missing types

@faif
Copy link
Owner

faif commented May 4, 2025

The changes look good. Do you know why the linter fails?

@cdorsman
Copy link
Contributor Author

cdorsman commented May 4, 2025

@faif Mainly because several linters founded errors in the code-base.

Unfortunately the setup of the GitHub Actions workflow with an embedded script with a wide variety of linters is not really effective, because you are not able to see which linter is failing and the reason behind it.

From a user perspective, it is not user friendly as well, because lint.sh just installs the packages system-wide instead in a virtualenv.

In my humble opinion. It
would be more effective, if the pipeline/workflow would be adjusted to execute a linter step by step.

This will improve the efficiency greatly.

@cdorsman
Copy link
Contributor Author

cdorsman commented May 4, 2025

I have added a adjusted lint_python workflow where all the linters are executed but per step.

You now see what and why a linter fails. For now, I added the option to continue on error, so that there is room to fix all the problems.

@cdorsman
Copy link
Contributor Author

cdorsman commented May 4, 2025

I also added a workflow that lints per PR and Pull and not everything (which is a lot)

You can decide what you want with it.

@faif faif merged commit ecc5e17 into faif:master May 7, 2025
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants