Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Single-Include Header Download and *nix Commands #46

Merged
merged 5 commits into from
Jun 9, 2019

Conversation

seldonwilson
Copy link
Contributor

The single-include header file used to link to the release-link instead of the actual header file which was in the assets of the provided link. New users might get confused when they aren't taken directly to the header file or when it doesn't begin downloading when they click the link, which is what happens now. Also, if you're working on the code in the different header files, you won't have an up-to-date single-include header, so I've added the command to generate that release header as a third bullet point to the "Using the command line" section of the README.

…lude header file in the Development section. Also, updated the "single-include header file" link to link to the actual header instead of the releases page. A new reference link was made for the header file in the assets section of the releases page.
Copy link
Owner

@faheel faheel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This will indeed be helpful for many.

There are some small changes that need to be made before the PR can merged:

@seldonwilson
Copy link
Contributor Author

@faheel, I just wanted to say thank you for engaging with me as I've fumbled around here. You seem like a great teacher and open person. These commits are for an open source class I'm taking at university and I've never involved myself with someone else's GitHub before, so I really appreciate the effort you put in with others and the tone you take. Thanks so much!

@faheel faheel merged commit 59f7cad into faheel:master Jun 9, 2019
@faheel
Copy link
Owner

faheel commented Jun 9, 2019

@seldonwilson, Thank YOU for engaging with open source software and contributing to it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants