Ensure that the first digit of a randomly generated BigInt is non-zero
#43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndom BigInt which contained leading zeros.
faheel
changed the title
BigInt is non-zero
faheel
requested changes
Jun 2, 2019
include/functions/random.hpp
Outdated
| @@ -32,6 +32,9 @@ BigInt big_random(size_t num_digits = 0) { | |||
|
|
|||
| BigInt big_rand; | |||
| big_rand.value = ""; // clear value to append digits | |||
|
|
|||
| // ensure first digit is non-zero | |||
| big_rand.value += std::to_string(rand_generator() % 8 + 1); | |||
There was a problem hiding this comment.
The expression should be be 1 + rand_generator() % 9.
There was a problem hiding this comment.
Wow, I'm a bozo. I'll fix that.
First digit would only be [1, 8], now it will be [1,9]
seldonwilson
commented
Jun 2, 2019
|
@seldonwilson Thank you for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generates the first digit of a random BigInt to be a value from one to nine, inclusive, guaranteeing there will be no leading zeros.
Closes #40.