Modify usage of sed to be compatible with macOS
#30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #30 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 13 13
Lines 536 536
=====================================
Hits 536 536Continue to review full report at Codecov.
|
faheel
force-pushed
the
master
branch
2 times, most recently
from
6bf4812 to
69dd72f
Compare
|
Good find! But instead of using a modified command to make it work on a different OS, I think we should use those commands that work the same on multiple OSs. So I suggest you change the sed "/#include \"*\"/d" "$release_file" > "$release_file.tmp"
mv "$release_file.tmp" "$release_file" |
faheel
changed the title
make release on Mac OS Xsed to be compatible with macOS
Also added lines to release shell
faheel
reviewed
May 14, 2018
scripts/release.sh
Outdated
| @@ -47,5 +47,5 @@ do | |||
| printf "\n\n" >> "$release_file" | |||
| done | |||
|
|
|||
| # delete includes for non-standard header files from the release file | |||
There was a problem hiding this comment.
Sorry about that, adding it back now.
faheel
approved these changes
May 14, 2018
|
Thank you for contributing! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mac OS uses a different
sedcommand from GNU. In order to use the-iflag you must pass the extension along with it so I added the.hppextension if darwin is detected as the OS.