Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention possibly excluded detail #26

Merged
merged 1 commit into from
Apr 18, 2018
Merged

Mention possibly excluded detail #26

merged 1 commit into from
Apr 18, 2018

Conversation

arnavb
Copy link
Contributor

@arnavb arnavb commented Apr 18, 2018

I think you meant to say header-only library since the sentence doesn't make much sense otherwise.

@codecov
Copy link

codecov bot commented Apr 18, 2018

Codecov Report

Merging #26 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #26   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          13     13           
  Lines         536    536           
=====================================
  Hits          536    536

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2b51ee...34ad404. Read the comment docs.

@faheel faheel merged commit 71dfecb into faheel:master Apr 18, 2018
@faheel
Copy link
Owner

faheel commented Apr 18, 2018

@arnavb Good catch! Thanks for the PR!

@arnavb arnavb deleted the patch-1 branch April 18, 2018 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants