feat(python): Register TPC-H connector #12318
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Enable PyVelox users to register TPC-H connector. Also refactoring the connector register/unregister methods to a separate compilation unit. Differential Revision: D69604556
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D69604556 |
✅ Deploy Preview for meta-velox canceled.
|
kKPulla
reviewed
Feb 14, 2025
|
|
||
| void registerHive(const std::string& connectorId) { | ||
| connector::registerConnectorFactory( | ||
| std::make_shared<connector::hive::HiveConnectorFactory>( |
There was a problem hiding this comment.
at least for these two connectors, looks like the only difference we have currently in implementation is the connector factory? If we see this will be a pattern, can we templatize this so we can reuse?
kKPulla
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Enable PyVelox users to register TPC-H connector. Also refactoring the
connector register/unregister methods to a separate compilation unit.
Differential Revision: D69604556