fix: Avoid invalid access into random region in memory in OperatorUtils #12253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: There are 2 bugs in processEncodedFilterResults: 1. We may call bits::isBitSet(values, index) and then rows.isValid(i), this means we may be passing in an invalid index to `bits::isBitSet(values, index)`. We need to call `rows.isValid(i)` before `bits::isBitSet(values, index)`. Because index may give a bogus value if it is not valid 2. We may access an invalid value in index via `auto index = indices[i];` if i is not valid. Fix is to check if the row is valid before processing Differential Revision: D69095863
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D69095863 |
✅ Deploy Preview for meta-velox canceled.
|
|
This pull request has been merged in 48d1bbf. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
There are 2 bugs in processEncodedFilterResults:
We may call bits::isBitSet(values, index) and then rows.isValid(i), this means we may be passing in an invalid index to
bits::isBitSet(values, index). We need to callrows.isValid(i)beforebits::isBitSet(values, index). Because index may give a bogus value if it is not validWe may access an invalid value in index via
auto index = indices[i];if i is not valid.Fix is to check if the row is valid before processing
Differential Revision: D69095863