feat(filesystem): Add set and get properties on directories #12247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D68650034 |
✅ Deploy Preview for meta-velox canceled.
|
yuandagits
added a commit
to yuandagits/velox
that referenced
this pull request
Feb 3, 2025
…or#12247) Summary: We'd like to set/get properties on directories if the remote filesystem supports APIs like TTL. In POSIX, this would be similar to ioctl. Simply expose a property bag for which users can use for setting key-value pairs for the set path, and on the get path, only support getting a single key for now. If the key is not present, nullopt is returned. Differential Revision: D68650034
yuandagits
force-pushed
the
export-D68650034
branch
from
53fab2b to
0d0efb0
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68650034 |
yuandagits
changed the title
yuandagits
added a commit
to yuandagits/velox
that referenced
this pull request
Feb 4, 2025
…or#12247) Summary: We'd like to set/get properties on directories if the remote filesystem supports APIs like TTL. In POSIX, this would be similar to ioctl. Simply expose a property bag for which users can use for setting key-value pairs for the set path, and on the get path, only support getting a single key for now. If the key is not present, nullopt is returned. Reviewed By: singcha Differential Revision: D68650034
yuandagits
force-pushed
the
export-D68650034
branch
from
0d0efb0 to
8c3eabb
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68650034 |
yuandagits
changed the title
yuandagits
added a commit
to yuandagits/velox
that referenced
this pull request
Feb 5, 2025
…or#12247) Summary: We'd like to set/get properties on directories if the remote filesystem supports APIs like TTL. In POSIX, this would be similar to ioctl. Simply expose a property bag for which users can use for setting key-value pairs for the set path, and on the get path, only support getting a single key for now. If the key is not present, nullopt is returned. Reviewed By: singcha Differential Revision: D68650034
yuandagits
force-pushed
the
export-D68650034
branch
from
8c3eabb to
c487234
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68650034 |
yuandagits
changed the title
yuandagits
changed the title
yuandagits
changed the title
|
what kind of properties do we plan to set/get? |
zation99
approved these changes
Feb 6, 2025
…or#12247) Summary: We'd like to set/get properties on directories if the remote filesystem supports APIs like TTL. In POSIX, this would be similar to ioctl. Simply expose a property bag for which users can use for setting key-value pairs for the set path, and on the get path, only support getting a single key for now. If the key is not present, nullopt is returned. Reviewed By: singcha, zation99 Differential Revision: D68650034
yuandagits
force-pushed
the
export-D68650034
branch
from
c487234 to
25650d2
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68650034 |
|
This pull request has been merged in 50c525a. |
hey sorry just saw this. I plan to set TTL on the directories |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We'd like to set/get properties on directories if the remote filesystem supports APIs like TTL. In POSIX, this would be similar to ioctl.
Simply expose a property bag for which users can use for setting key-value pairs for the set path, and on the get path, only support getting a single key for now. If the key is not present, nullopt is returned.
Differential Revision: D68650034