EZ const std:string -> string_view #12245
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: PROBLEM `RowType::containsChild()` takes a `string_view` , but if we want to get the index, we need to have a `std::string` . There isn't any specific reason for mandating the `const std::string&` in the interface, especially when the `findChild` API also uses a StringPiece. SOLUTION Change to use `std::string_view` Differential Revision: D69075102
|
This pull request was exported from Phabricator. Differential Revision: D69075102 |
facebook-github-bot
added
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
PROBLEM
RowType::containsChild()takes astring_view, but if we want to get the index, we need to have astd::string.There isn't any specific reason for mandating the
const std::string&in the interface, especially when thefindChildAPI also uses a StringPiece.SOLUTION
Change to use
std::string_viewDifferential Revision: D69075102