Skip to content

Commit

Permalink
updating ctrlc from 3.4.0 to 3.4.5 for panic handling
Browse files Browse the repository at this point in the history
Summary:
updating ctrlc from 3.4.0 to 3.4.5 for panic handling

one of the consistent error groupings in the "Hargow Infrastructure Failure Impact" alarm is thread 'main' panicked at 'failed to spawn thread: Os { code: 11, kind: WouldBlock, message: "Resource temporarily unavailable" }', third-party/rust/vendor/ctrlc-3.4.0/src/lib.rs:150:10

looks like a persistent problem that's been happening as far as back as our logs go https://fburl.com/scuba/hargow/ae4nvino

the code in question calls an expect() which sometimes fails to createa thread, panicing the app
good news, this is [fixed upstream](Detegr/rust-ctrlc@b543abe) by swapping the expect with a map_err

Reviewed By: wtetzner, mbassale, dtolnay

Differential Revision: D62211602

fbshipit-source-id: 5242bf426bfd5d733f1842d75836e63e45d04a1f
  • Loading branch information
Nick York authored and facebook-github-bot committed Sep 5, 2024
1 parent 2bbaed2 commit 02a16a4
Showing 1 changed file with 33 additions and 26 deletions.
59 changes: 33 additions & 26 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 02a16a4

Please sign in to comment.