Skip to content

Commit

Permalink
Omit unsupported lines for OSS
Browse files Browse the repository at this point in the history
Summary:
Fixing oss build failure: https://www.internalfb.com/sandcastle/workflow/3233584532457644543

Logger doesn't seem to work in oss.. skipping them

Reviewed By: r39xu

Differential Revision: D67985573

fbshipit-source-id: e2b98f2ac90fcdbf515539323757f9f2b5a1f2ce
  • Loading branch information
Xiang Gao authored and facebook-github-bot committed Jan 9, 2025
1 parent 0c29954 commit bbad975
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion td_util/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ pub mod qe;
pub mod schedules;
pub mod string;
pub mod supertd_events;
pub mod supertd_events_logger;
// @oss-disable: pub mod supertd_events_logger;
pub mod tracing;
pub mod workflow_error;
pub mod xplat;
Expand Down
4 changes: 2 additions & 2 deletions td_util/src/supertd_events.rs
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ pub enum Step {
/// for writing.
pub fn init(fb: fbinit::FacebookInit) -> ScubaClientGuard {
if should_use_logger() {
crate::supertd_events_logger::init(fb);
// @oss-disable: crate::supertd_events_logger::init(fb);
} else {
let mut builder = match std::env::var_os("SUPERTD_SCUBA_LOGFILE") {
None => ScubaSampleBuilder::new(fb, SCUBA_DATASET),
Expand Down Expand Up @@ -123,7 +123,7 @@ pub fn init(fb: fbinit::FacebookInit) -> ScubaClientGuard {
macro_rules! scuba {
( event: $event:ident $(, $key:ident : $value:expr)* $(,)? ) => {
if $crate::supertd_events::should_use_logger() {
$crate::scuba_logger! {event: $event $(, $key : $value)*};
// @oss-disable: $crate::scuba_logger! {event: $event $(, $key : $value)*};
} else {
let mut builder = $crate::supertd_events::sample_builder();
builder.add("event", format!("{:?}", &$crate::supertd_events::Event::$event));
Expand Down

0 comments on commit bbad975

Please sign in to comment.