add minimal support for aarch64 #507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D61661524 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #507 +/- ##
==========================================
- Coverage 60.80% 60.79% -0.01%
==========================================
Files 126 127 +1
Lines 12493 12498 +5
Branches 2014 2014
==========================================
+ Hits 7596 7598 +2
- Misses 3940 3943 +3
Partials 957 957 ☔ View full report in Codecov by Sentry. |
|
This pull request was exported from Phabricator. Differential Revision: D61661524 |
JakeHillion
added a commit
to JakeHillion/object-introspection
that referenced
this pull request
Aug 22, 2024
Summary: Pull Request resolved: facebookexperimental#507 OI is currently completely incompatible with anything except `x86_64`. Changing that generally is a big effort, but `oilgen` should work on other architectures. Begin adding some support for `aarch64` architecture. This change sets up a file structure for architecture support. It pulls the 2 functions needed to make `Descs.{h,cpp}` architecture agnostic into architecture specific files for `x86_64` and `aarch64`. This enables `oilgen` (the binary) to build. At this stage `oilgen` is unable to generate working code for `aarch64`, but at least this is a step in the right direction. Differential Revision: D61661524
JakeHillion
force-pushed
the
export-D61661524
branch
from
3fb08b4 to
39451c3
Compare
Summary: Pull Request resolved: facebookexperimental#507 OI is currently completely incompatible with anything except `x86_64`. Changing that generally is a big effort, but `oilgen` should work on other architectures. Begin adding some support for `aarch64` architecture. This change sets up a file structure for architecture support. It pulls the 2 functions needed to make `Descs.{h,cpp}` architecture agnostic into architecture specific files for `x86_64` and `aarch64`. This enables `oilgen` (the binary) to build. At this stage `oilgen` is unable to generate working code for `aarch64`, but at least this is a step in the right direction. Differential Revision: D61661524
JakeHillion
force-pushed
the
export-D61661524
branch
from
39451c3 to
c70d6b2
Compare
|
This pull request was exported from Phabricator. Differential Revision: D61661524 |
ajor
approved these changes
Aug 23, 2024
|
|
||
| void setProgramCounter(user_regs_struct& regs, uintptr_t pc); | ||
|
|
||
| std::optional<uintptr_t> getReturnValueAddress(const user_regs_struct&); |
There was a problem hiding this comment.
I mainly did this to match the existing API, though it was never optional there either. This way it might be possible to part implement an architecture if it's ever difficult to get the return value/guess an arg position in future.
facebook-github-bot
merged commit b7b9ac1
into
facebookexperimental:main
13 of 14 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
OI is currently completely incompatible with anything except
x86_64. Changing that generally is a big effort, butoilgenshould work on other architectures. Begin adding some support foraarch64architecture.This change sets up a file structure for architecture support. It pulls the 2 functions needed to make
Descs.{h,cpp}architecture agnostic into architecture specific files forx86_64andaarch64. This enablesoilgen(the binary) to build. At this stageoilgenis unable to generate working code foraarch64, but at least this is a step in the right direction.Differential Revision: D61661524