Fix CodeGen V2 for zero-length array #453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ttreyer
added
bug
The recursive template implemented for `validate_size` does not support incomplete types, like zero-length array. By splitting the `validate_size` struct in two parts: 1. `validate_size_eq` that does the actual size check, and 2. `validate_size` that preserves the previous interface and inherit from `validate_size_eq`, we get the same interface and feature than previously, but without the recursive template that doesn't support incomplete types.
ttreyer
force-pushed
the
ttreyer/fix-zero-array
branch
from
62a3778 to
cff773b
Compare
JakeHillion
reviewed
Jan 10, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #453 +/- ##
==========================================
+ Coverage 62.38% 62.41% +0.02%
==========================================
Files 123 123
Lines 12007 12006 -1
Branches 1956 1955 -1
==========================================
+ Hits 7491 7493 +2
+ Misses 3571 3570 -1
+ Partials 945 943 -2 ☔ View full report in Codecov by Sentry. |
ttreyer
force-pushed
the
ttreyer/fix-zero-array
branch
from
cff773b to
ec40543
Compare
TreeBuilder did not consider a zero-length array like a container and never read the array's sizeof stored in the data buffer, leading to a mismatch between bytes written vs read out of the buffer. Now, `TreeBuilder::isContainer` does consider zero-length array like a container and properly consume all the object sizes in the buffer.
ttreyer
force-pushed
the
ttreyer/fix-zero-array
branch
from
ec40543 to
6a26f9a
Compare
JakeHillion
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix issue #295
validate_sizetemplate with a non-recursive one, making CodeGen compileIs it ok to process zero-length array as container?
I had to modify the test's results to all
0sizes. Is this the behavior expected? Or should it report an exclusive size of1for theFoostruct?Test plan
The example provided in #295 now passes successfully and has been enabled in the integration tests.