type_graph: avoid overwriting explicitly set alignment

[JakeHillion]

type_graph: avoid overwriting explicitly set alignment

Previously AlignmentCalc calculates the alignment and sets packing for every
type except a member with explicit alignment. Change this to check whether an
alignment has been previously set for a type before calculating it. Use this in
ClangTypeParser where the full alignment of the type is available.

Remove explicitly aligning members by the type because that was previously
reserved for members with explicit alignment. AlignmentCalc will correctly
align a member to the underlying type without this. Explicit member alignment
is still missing, as before this change.

Test plan:

• CI
• Too little. Gets further into a production type than without this change.

[codecov-commenter]

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (31ba865) 62.50% compared to head (09dd1cb) 62.48%.

Files	Patch %	Lines
oi/type_graph/AlignmentCalc.cpp	80.00%	0 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #443      +/-   ##
==========================================
- Coverage   62.50%   62.48%   -0.02%     
==========================================
  Files         123      123              
  Lines       12067    12068       +1     
  Branches     1965     1966       +1     
==========================================
- Hits         7542     7541       -1     
- Misses       3571     3572       +1     
- Partials      954      955       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ajor]

No tests for ClangTypeParser? 😢

[JakeHillion]

No tests for ClangTypeParser? 😢

Unfortunately not... I was hoping to enable all the integration tests and get coverage that way then add unit tests later. The integration tests PR is stalled because of the build system stuff so I might look into adding unit tests similar to DrgnParser next week - it's also not trivial though because it needs the compilation command of the integration test target and not just the compiled binary from CMake.