fix: one-pager decomp labels and warning (#1011) (CRAN v3.11.1)

facebookexperimental · Jun 27, 2024 · 765e4d8 · 765e4d8
1 parent 6afc50b
commit 765e4d8
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/R/DESCRIPTION b/R/DESCRIPTION
@@ -1,7 +1,7 @@
 Package: Robyn
 Type: Package
 Title: Semi-Automated Marketing Mix Modeling (MMM) from Meta Marketing Science 
-Version: 3.11.0
+Version: 3.11.1
 Authors@R: c(
     person("Gufeng", "Zhou", , "gufeng@meta.com", c("aut")),
     person("Bernardo", "Lares", , "laresbernardo@gmail.com", c("cre","aut")),

diff --git a/R/R/plots.R b/R/R/plots.R
@@ -427,7 +427,7 @@ robyn_onepagers <- function(
           sign = as.factor(ifelse(.data$xDecompPerc >= 0, "Positive", "Negative"))
         )
 
-      p2 <- ggplot(plotWaterfallLoop, aes(x = .data$id, fill = .data$sign)) +
+      p2 <- ggplot(plotWaterfallLoop, aes(x = .data$rn, fill = .data$sign)) +
         geom_rect(aes(
           xmin = .data$id - 0.45, xmax = .data$id + 0.45,
           ymin = .data$end, ymax = .data$start
@@ -437,6 +437,7 @@ robyn_onepagers <- function(
         scale_fill_manual(values = c("Positive" = "#59B3D2", "Negative" = "#E5586E")) +
         theme_lares(background = "white", legend = "top") +
         geom_text(mapping = aes(
+          x = .data$id,
           label = paste0(
             formatNum(.data$xDecompAgg, abbr = TRUE),
             "\n", round(.data$xDecompPerc * 100, 1), "%"