From 7d4a6ab76691f555dcef0ed08407f20e806ab7ef Mon Sep 17 00:00:00 2001 From: Jon Maltiel Swenson Date: Fri, 7 Feb 2025 12:19:15 -0800 Subject: [PATCH] Remove getdeps dependency on Python 3.8 Summary: X-link: https://github.com/facebookincubator/zstrong/pull/1175 Instead of having fbthrift download and build Python 3.8 (which is ancient), users should be able to build fbthrift against the target Python environment. (This is consistent with how Python packages would normally be built/installed.) Note that users can specify their target version of Python via the `PYTHON_LIBRARY` and `PYTHON_INCLUDE_DIR` CMake variables, as demonstrated in the command in the test plan. Reviewed By: vladmihailescu Differential Revision: D68510340 fbshipit-source-id: f94805de4220b2c107ed0aa0d57fd23b65b29bd2 --- build/fbcode_builder/manifests/fbthrift | 5 ----- 1 file changed, 5 deletions(-) diff --git a/build/fbcode_builder/manifests/fbthrift b/build/fbcode_builder/manifests/fbthrift index 803163ccb39fb..c3b8e0d0729b8 100644 --- a/build/fbcode_builder/manifests/fbthrift +++ b/build/fbcode_builder/manifests/fbthrift @@ -31,11 +31,6 @@ xxhash # specific configuration we rely on the folly manifest to provide this # dependency to avoid duplication. -[dependencies.os=linux] -# python doesn't build on Windows yet and this causes python3 shebangs to -# expand to a non-portable path on macOS -python - [shipit.pathmap] xplat/thrift/public_tld = . xplat/thrift = thrift