Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flag to remove www console forks #32058

Merged
merged 3 commits into from
Jan 15, 2025
Merged

Flag to remove www console forks #32058

merged 3 commits into from
Jan 15, 2025

Conversation

rickhanlonii
Copy link
Member

@rickhanlonii rickhanlonii commented Jan 13, 2025 •
edited
Loading

Let's remove these

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Jan 13, 2025
@react-sizebot
Copy link

react-sizebot commented Jan 13, 2025 •
edited
Loading

Comparing: 886c5ad...1888590

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 514.24 kB 514.24 kB = 91.74 kB 91.74 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 556.18 kB 556.18 kB = 98.72 kB 98.72 kB
facebook-www/ReactDOM-prod.classic.js = 595.79 kB 595.79 kB = 104.85 kB 104.85 kB
facebook-www/ReactDOM-prod.modern.js = 586.21 kB 586.21 kB = 103.30 kB 103.30 kB
facebook-www/ReactReconcilerConstants-dev.classic.js +6.48% 0.60 kB 0.64 kB +2.33% 0.34 kB 0.35 kB
facebook-www/ReactReconcilerConstants-dev.modern.js +6.48% 0.60 kB 0.64 kB +2.33% 0.34 kB 0.35 kB
facebook-www/ReactCacheOld-dev.classic.js +5.17% 7.00 kB 7.36 kB +5.30% 2.02 kB 2.13 kB
facebook-www/ReactCacheOld-dev.modern.js +5.17% 7.00 kB 7.36 kB +5.30% 2.02 kB 2.13 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
facebook-www/ReactReconcilerConstants-dev.classic.js +6.48% 0.60 kB 0.64 kB +2.33% 0.34 kB 0.35 kB
facebook-www/ReactReconcilerConstants-dev.modern.js +6.48% 0.60 kB 0.64 kB +2.33% 0.34 kB 0.35 kB
facebook-www/ReactCacheOld-dev.classic.js +5.17% 7.00 kB 7.36 kB +5.30% 2.02 kB 2.13 kB
facebook-www/ReactCacheOld-dev.modern.js +5.17% 7.00 kB 7.36 kB +5.30% 2.02 kB 2.13 kB
facebook-www/JSXDEVRuntime-dev.classic.js +1.29% 28.08 kB 28.45 kB +1.32% 6.60 kB 6.69 kB
facebook-www/JSXDEVRuntime-dev.modern.js +1.29% 28.08 kB 28.45 kB +1.32% 6.60 kB 6.69 kB
facebook-www/React-dev.modern.js +0.65% 70.52 kB 70.98 kB +0.64% 15.40 kB 15.50 kB
facebook-www/React-dev.classic.js +0.65% 70.53 kB 70.98 kB +0.64% 15.40 kB 15.50 kB

Generated by 🚫 dangerJS against 4d6b21e

@rickhanlonii rickhanlonii marked this pull request as ready for review January 13, 2025 22:37
@rickhanlonii
Copy link
Member Author

Good luck to whoever tries to remove this in the future

@rickhanlonii rickhanlonii reopened this Jan 15, 2025
@rickhanlonii
Copy link
Member Author

I tried harder and I think I got it

@rickhanlonii rickhanlonii merged commit 0597605 into facebook:main Jan 15, 2025
186 checks passed
github-actions bot pushed a commit that referenced this pull request Jan 15, 2025
@rickhanlonii
Flag to remove www console forks (#32058)
7f2fdaa 
Let's remove these

DiffTrain build for [0597605](0597605)
@rickhanlonii rickhanlonii deleted the rh/rm-patches branch January 15, 2025 14:30
@vercel-release-bot vercel-release-bot mentioned this pull request Jan 15, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebmarkbage sebmarkbage sebmarkbage approved these changes

@hoxyq hoxyq hoxyq approved these changes

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rickhanlonii @react-sizebot @sebmarkbage @hoxyq @facebook-github-bot