From d0f84e37717f62ced01650733f6c4b8d4881b5aa Mon Sep 17 00:00:00 2001 From: Andrew Regner Date: Wed, 28 Jun 2023 11:16:07 -0700 Subject: [PATCH] Fix ROCKSDB_PLUGIN typo in get_rocksdb_files.sh I'm guessing this was copy/pasted from a Makefile sort of syntax, whereas it meant to include the contents of these environment variables in this bash script. When I tried to build mysqld from this it was crashing here saying things like `ROCKSDB_PLUGIN_BUILTINS: command not found` because this syntax in bash means to execute a subcommand. --- storage/rocksdb/get_rocksdb_files.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/storage/rocksdb/get_rocksdb_files.sh b/storage/rocksdb/get_rocksdb_files.sh index 756bc9ec25bb..2776ab62cfb7 100755 --- a/storage/rocksdb/get_rocksdb_files.sh +++ b/storage/rocksdb/get_rocksdb_files.sh @@ -37,7 +37,7 @@ then sed -e s/@GIT_SHA@/$git_sha/ -e s:@GIT_TAG@:"$git_tag": \ -e s/@GIT_MOD@/"$git_mod"/ -e s/@BUILD_DATE@/"$build_date"/ \ -e s/@GIT_DATE@/"$git_date"/ \ - -e s/@ROCKSDB_PLUGIN_BUILTINS@/"$(ROCKSDB_PLUGIN_BUILTINS)"/ \ - -e s/@ROCKSDB_PLUGIN_EXTERNS@/"$(ROCKSDB_PLUGIN_EXTERNS)"/ \ + -e s/@ROCKSDB_PLUGIN_BUILTINS@/"$ROCKSDB_PLUGIN_BUILTINS"/ \ + -e s/@ROCKSDB_PLUGIN_EXTERNS@/"$ROCKSDB_PLUGIN_EXTERNS"/ \ rocksdb/util/build_version.cc.in > $bv fi