Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ROCKSDB_PLUGIN typo in get_rocksdb_files.sh #1335

Open
wants to merge 1 commit into
base: fb-mysql-8.0.28
Choose a base branch
from

Conversation

adregner
Copy link

I'm guessing this was copy/pasted from a Makefile sort of syntax, whereas it meant to include the contents of these environment variables in this bash script. When I tried to build mysqld from this it was crashing here saying things like ROCKSDB_PLUGIN_BUILTINS: command not found because this syntax in bash means to execute a subcommand.

I'm guessing this was copy/pasted from a Makefile sort of syntax, whereas it meant to include the contents of these environment variables in this bash script.  When I tried to build mysqld from this it was crashing here saying things like `ROCKSDB_PLUGIN_BUILTINS: command not found` because this syntax in bash means to execute a subcommand.
@facebook-github-bot
Copy link

Hi @adregner!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants