Update create-tag.yml for Hermes #1514
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@cortinico merged this pull request in c4767b0. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Sep 13, 2024
Summary: Original Author: corti.nico@gmail.com Original Git: c4767b0 Original Reviewed By: cipolleschi Original Revision: D62381946 This is just a nit because this string is not entirely correct. Pull Request resolved: #1514 Pulled By: cortinico Reviewed By: davedets Differential Revision: D62456471 fbshipit-source-id: 78fdaad43dbcbbc4ccb1127ad9e757117f28a21a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is just a nit because this string is not entirely correct.
Test Plan
Nothing to test