Resolve several Java warnings on Hermes Intl (#1553)

Summary: Pull Request resolved: #1553 This clears up all the warnings in Intl coming from Xdeprecated and Xunchecked Reviewed By: neildhar Differential Revision: D65135162 fbshipit-source-id: 95796e29b23f1aad680e63c648da7e9b5524b75a
facebook · Oct 30, 2024 · 0b92287 · 0b92287
1 parent 5ce6d23
commit 0b92287
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 4 deletions.
diff --git a/lib/Platform/Intl/java/com/facebook/hermes/intl/JSObjects.java b/lib/Platform/Intl/java/com/facebook/hermes/intl/JSObjects.java
@@ -61,11 +61,11 @@ public static boolean isBoolean(Object object) {
   }
 
   public static Object newBoolean() {
-    return new Boolean(false);
+    return Boolean.FALSE;
   }
 
   public static Object newBoolean(boolean b) {
-    return new Boolean(b);
+    return b;
   }
 
   public static Object newBoolean(String str) {
@@ -81,7 +81,7 @@ public static boolean isNumber(Object object) {
   }
 
   public static Object newNumber(double d) {
-    return new Double(d);
+    return d;
   }
 
   public static double getJavaDouble(Object object) {
@@ -100,6 +100,7 @@ public static boolean isObject(Object object) {
     return object instanceof HashMap;
   }
 
+  @SuppressWarnings("unchecked")
   public static Map<String, Object> getJavaMap(Object object) {
     return (HashMap<String, Object>) object;
   }
@@ -108,6 +109,7 @@ public static Object newObject() {
     return new HashMap<String, Object>();
   }
 
+  @SuppressWarnings("unchecked")
   public static Object Get(Object options, String property) {
     HashMap<String, Object> javaObject = (HashMap<String, Object>) options;
     if (javaObject.containsKey(property)) {
@@ -119,6 +121,7 @@ public static Object Get(Object options, String property) {
     }
   }
 
+  @SuppressWarnings("unchecked")
   public static void Put(Object options, String property, Object value) {
     HashMap<String, Object> javaObject = (HashMap<String, Object>) options;
     javaObject.put(property, value);

diff --git a/lib/Platform/Intl/java/com/facebook/hermes/intl/LocaleIdentifier.java b/lib/Platform/Intl/java/com/facebook/hermes/intl/LocaleIdentifier.java
@@ -872,7 +872,7 @@ static void parseOtherExtensions(
     }
 
     ArrayList<String> otherExtensions = new ArrayList<>();
-    parsedLocaleIdentifier.otherExtensionsMap.put(new Character(singleton), otherExtensions);
+    parsedLocaleIdentifier.otherExtensionsMap.put(Character.valueOf(singleton), otherExtensions);
 
     while (nextSubtag.isOtherExtension()) {
 

diff --git a/lib/Platform/Intl/java/com/facebook/hermes/intl/PlatformNumberFormatterICU.java b/lib/Platform/Intl/java/com/facebook/hermes/intl/PlatformNumberFormatterICU.java
@@ -45,6 +45,7 @@ public class PlatformNumberFormatterICU implements IPlatformNumberFormatter {
   PlatformNumberFormatterICU() {}
 
   @RequiresApi(api = Build.VERSION_CODES.N)
+  @SuppressWarnings("deprecation")
   private void initialize(
       NumberFormat numberFormat,
       ILocaleObject<?> localeObject,