Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Summary: Thanks for proposing a pull request! To help us review the request, please complete the following: - [x] sign [contributor license agreement](https://developers.facebook.com/opensource/cla) - [x] I've ensured that all existing tests pass and added tests (when/where necessary) - [x] I've updated the documentation (when/where necessary) and [Changelog](CHANGELOG.md) (when/where necessary) - [x] I've added the proper label to this pull request (e.g. `bug` for bug fixes) ## Pull Request Details Added a `Package.swift` manifest. Updated imports to be non-modular for non-cocoapod setups. Updated dynamic framework loader to compile with arc. - This should be checked. Not 100% sure I did not cause a regression. Added a directory of symlinks to public header files - this was to get around a limitation in the SPM api where they will only accepts a path to header files (forces them to be located in the same directory) and not a list of header files. Pull Request resolved: #1073 Test Plan: **SPM:** `cd fbsource/fbobjc/ios-sdk` Initialize a new repository, add all the files and create a new commit on master. `git init` `git add .` `git commit -m "new commit"` Open the package itself with >= Xcode 11 by opening `Package.swift` instead of the usual project and verify that it builds Open a new project with >= Xcode 11 and add a new swift package. For the Package Repository field put the path to the sdk. `file:///Users/$whoami/fbsource/fbobjc/ios-sdk` then specify the branch as `master`. This sample project should build and you should be able to consume the kits with `import FBSDKCoreKit` or `FacebookCore` (for the Swift variant), `import FBSDKLoginKit` or `import FacebookLogin` and `import FBSDKShareKit` or `import FacebookShare`. Make sure that LoginKit and ShareKit also expose CoreKit symbols. **Xcode:** Can build all schemes as expected `BuildAllKits` `FBSDKTVOSKit-Universal` `FBSDKTVOSKit-Dynamic` `SwiftKits` **CocoaPods:** `cd fbsource/fbojbc/ios-sdk` `bundle exec pod lib lint FBSDKCoreKit.podspec` `bundle exec pod lib lint FBSDKLoginKit.podspec --include-podspecs=FBSDKCoreKit.podspec --allow-warnings` `bundle exec pod lib lint FBSDKShareKit.podspec --include-podspecs=FBSDKCoreKit.podspec --allow-warnings` **BUCK:** `cd fbsource/fbobjc/ios-sdk` `buck build ios-sdk:FBSDKCoreKit` `buck build ios-sdk:FBSDKLoginKit` `buck build ios-sdk:FBSDKShareKit` Also all of the other BUCK targets (will be covered by sandcastle) Reviewed By: dreamolight Differential Revision: D17879652 Pulled By: joesus fbshipit-source-id: d931140d0fb3b554f1e29e5c2af7e2173316670d
- Loading branch information
1 parent
26833c5
commit f3be0da