Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separating out functions #37

Open
ameliejyc opened this issue Nov 10, 2017 · 0 comments
Open

Separating out functions #37

ameliejyc opened this issue Nov 10, 2017 · 0 comments

Comments

@ameliejyc
Copy link

There are a few places where you could abstract out parts of your functions into smaller functions.

This makes your code cleaner, easier to read and see where things live, easier to modify and easier to test.

So for example, your API url is being created in your XHR request. This could be abstracted out into a createAPIUrl function and then tested to make sure it's being built correctly every time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant