Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a couple of css things #50

Open
mattlub opened this issue Feb 11, 2018 · 0 comments
Open

a couple of css things #50

mattlub opened this issue Feb 11, 2018 · 0 comments

Comments

@mattlub
Copy link

mattlub commented Feb 11, 2018

A couple of points/ideas

  • I think the css could be split into multiple files, and potentially matched to the specific components.
  • And some of the class names e.g. main-left-div, main-right-div are problematic (they might clash with future html elements, and they are not clear semantically)

I would recommend choosing a certain strategy (e.g. BEM) and trying to stick to it (and document it?!), because imagine if someone had to take over the project and try to continue with the CSS 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant