Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the testing task and workflow #30

Merged
merged 6 commits into from
Jan 6, 2024
Merged

Improve the testing task and workflow #30

merged 6 commits into from
Jan 6, 2024

Conversation

faboshka
Copy link
Owner

@faboshka faboshka commented Jan 5, 2024

This PR adds a couple of improvements to the testing task and workflow:

  • Separate test dependencies from the dev dependencies
    • This way there'd be less packages to install during the poetry install command in the testing workflow
    • This doesn't help the lint flow as we're usually linting the whole codebase including the tests
  • Parallelize the tests running across all cores
    • This does improve the execution time a bit but the improvement is negligible as the whole test suite takes ~3 seconds to test
    • Adding this because it is cool 😃
  • Change the test reporter used to a fork of dorney's test reporter
    • Replaced in order to allow for step-summary instead of an additional check (cleaner look)
  • Add GitHub annotations to the failed tests using a plugin to be installed on the GitHub testing workflow run
  • Have the summary be only a summary (without listing the issues and without annotations) as there is a different plugin for it now

@faboshka faboshka added the ci/cd CI/CD related issues or pull requests label Jan 5, 2024
@faboshka faboshka self-assigned this Jan 5, 2024
@faboshka faboshka force-pushed the improve_test_runs branch 2 times, most recently from 56c323c to 5248f5a Compare January 5, 2024 21:49
@faboshka faboshka force-pushed the improve_test_runs branch 9 times, most recently from 980b166 to b39b34c Compare January 5, 2024 23:19
@faboshka faboshka changed the title Improve tests running and workflow Improve testing task and workflow Jan 6, 2024
@faboshka faboshka changed the title Improve testing task and workflow Improve the testing task and workflow Jan 6, 2024
@faboshka faboshka merged commit 410f40c into main Jan 6, 2024
4 checks passed
@faboshka faboshka deleted the improve_test_runs branch January 6, 2024 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/cd CI/CD related issues or pull requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant