Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement indentation rules #1

Open
craftzdog opened this issue Feb 14, 2020 · 3 comments
Open

Implement indentation rules #1

craftzdog opened this issue Feb 14, 2020 · 3 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@craftzdog
Copy link

Hi, thanks for making this! No coffeescript dependency is what I was searching for.
But it doesn't work as expected. For example:

'global':
  'cmd-shift-y': 'application:toggle-main-window'
'body':
  'cmd-shift-s': 'core:sync-db'
'.CodeMirror textarea':
  'alt-shift-F': 'native!'

Yields actually:

{
  "global": {
    "cmd-shift-y": "application:toggle-main-window",
    "body": {
      "cmd-shift-s": "core:sync-db",
      ".CodeMirror textarea": {
        "alt-shift-F": "native!"
      }
    }
  }
}

Expected:

{
  "global": {
    "cmd-shift-y": "application:toggle-main-window"
  },
  "body": {
    "cmd-shift-s": "core:sync-db",
  },
  ".CodeMirror textarea": {
    "alt-shift-F": "native!"
  }
}

Could you look into it? Thanks in advance!

@fabiospampinato
Copy link
Owner

Indentation rules are kind of unimplemented yet:

//TODO: Implement indentation rules

They seemed pretty tricky to implement and I actually didn't need this, so I didn't implement them.

PR welcome though.

@fabiospampinato fabiospampinato added enhancement New feature or request help wanted Extra attention is needed labels Feb 14, 2020
@fabiospampinato fabiospampinato changed the title Object is unexpectedly nested Implement indentation rules Feb 14, 2020
@fabiospampinato
Copy link
Owner

fabiospampinato commented Apr 2, 2021

This should be rewritten with reghex, which should be pretty fun to do and would make the library smaller and faster.

@craftzdog
Copy link
Author

Cool😍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants