$.fn.removeClass: fixed attribute resetting

fabiospampinato · May 16, 2018 · 4e91cfa · 4e91cfa
1 parent cff93d0
commit 4e91cfa
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/src/attributes/remove_class.js b/src/attributes/remove_class.js
@@ -1,6 +1,7 @@
 
+// @require ./attr.js
 // @require ./toggle_class.js
 
 fn.removeClass = function ( cls ) {
-  return this.toggleClass ( cls, false );
+  return !arguments.length ? this.attr ( 'class', '' ) : this.toggleClass ( cls, false );
 };
diff --git a/src/attributes/toggle_class.js b/src/attributes/toggle_class.js
@@ -7,7 +7,7 @@ fn.toggleClass = function ( cls, force ) {
   const classes = getSplitValues ( cls ),
         isForce = ( force !== undefined );
 
-  if ( !classes.length ) return ( isForce && !force ) ? this.attr ( 'class', '' ) : this;
+  if ( !classes.length ) return this;
 
   return this.each ( ( i, ele ) => {
     each ( classes, c => {

diff --git a/test/index.js b/test/index.js
@@ -153,7 +153,7 @@ QUnit.test( "removeClass", function( assert ) {
   assert.equal( $('.attr-fixture2')[0].className, "attr-fixture2", "removeClass Multiple Passed!" );
 
   $cf.removeClass();
-  assert.equal( $cf.className, undefined, 'removing all classes passed!' );
+  assert.equal( $cf[0].className, '', 'removing all classes passed!' );
   $cf.addClass('class-fixture');
 
   var hasClass = $('.attr-fixture').addClass('foo$bar').removeClass('foo$bar').hasClass('foo$bar');