Add missing FluidSynth checks, consistency tweak

[MrAlaux]

Should fix this Doomworld report.

While we're on this, I noticed that the following check uses #ifdef instead of #if defined:

woof/src/i_oalmusic.c

Lines 612 to 617 in 1640988

	#ifdef HAVE_FLUIDSYNTH
	if (active_module == &stream_fl_module)
	{
	return midiplayer_fluidsynth;
	}
	#endif

Why? Should we change it or all the others for consistency?

[fabiangreffrath]

Why? Should we change it or all the others for consistency?

#ifdef and #if defined() are completely synonymous, but I agree it would be nice to use only one way of writing for consistency. I prefer the latter, because it's possible to combine it with other checks, e.g. #if defined(foo) && defined(bar).

[MrAlaux]

#ifdef and #if defined() are completely synonymous, but I agree it would be nice to use only one way of writing for consistency. I prefer the latter, because it's possible to combine it with other checks, e.g. #if defined(foo) && defined(bar).

So, do I make the change in this PR?

[fabiangreffrath]

So, do I make the change in this PR?

Yes, please.

[MrAlaux]

So, do I make the change in this PR?

Yes, please.

Done in a720d33.

[fabiangreffrath]

Thank you!

I can confirm that the engine now compiles and runs if fluidsynth is not installed at build time. However, could you please address these warnings as well:

[69/188] Building C object src/CMakeFiles/woof.dir/i_oalmusic.c.o
/home/fabian/Source/woof/src/i_oalmusic.c:442:12: warning: ‘fl_gain’ defined but not used [-Wunused-variable]
  442 | static int fl_gain, opl_gain;
      |            ^~~~~~~
[135/188] Building C object src/CMakeFiles/woof.dir/mn_setup.c.o
/home/fabian/Source/woof/src/mn_setup.c:2495:13: warning: ‘SetMidiPlayerFluidSynth’ defined but not used [-Wunused-function]
 2495 | static void SetMidiPlayerFluidSynth(void)
      |             ^~~~~~~~~~~~~~~~~~~~~~~

[MrAlaux]

However, could you please address these warnings as well

Will do tomorrow.

[MrAlaux]

Will do tomorrow.

Done in 6957e20.

[fabiangreffrath]

Great, thank you!