Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a comprehensive set of example data #156

Open
rob-luke opened this issue Sep 13, 2024 · 3 comments
Open

Create a comprehensive set of example data #156

rob-luke opened this issue Sep 13, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@rob-luke
Copy link
Member

Both raw and processed data

(as discussed in sfnirs conference)

@fangq
Copy link
Member

fangq commented Sep 15, 2024

hi @rob-luke and @dboas, with the changes I just made in NeuroJSON/jsnirfy@e5e3fb5 and NeuroJSON/easyh5@2090320, all snirf files in the snirf-samples now can pass the validator - the only exception is the minimum_example.snirf but I believe it is due to a bug in the validator (which I filed here: BUNPC/pysnirf2#49).

I think all of you should have write permission to snirf-samples. feel free to add additional files. I suggest keeping the data size relatively small, but keep the data/file type diverse. it would be great for software testing purposes.

Currently, a JSON file (.jsnirf) is serving as the "source-code" for each sample data, and use a matlab script to convert it to .snirf. I feel this way, people can use the json file to understand the data structure, but once converted to .snirf, it is no longer human readable. I am happy to create these .jsnirf files if you upload new .snirf files.

@OliverF2022
Copy link

Could you provide an example using nirs[i]/measurementList[i]/dataTypeLabel? I couldn't find any example files that used this label. I'm not quite sure how this label helps confirm the information in dataTimeSeries. Thanks. @fangq

@fangq
Copy link
Member

fangq commented Oct 16, 2024

measurementList(i).dataTypeLabel is a string specifying what type of (processed) data stored in the dataTimeSeries, allowed values are

https://github.com/fNIRS/snirf/blob/master/snirf_specification.md#supported-measurementlistkdatatypelabel-values-in-datatimeseries

one should use this to store data analysis software output data - such as those estimated by HOMER or BrainAnalyzIR. If anyone has a sample file and would like to add it to snirf-samples, please share the link, preferable a small sized file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants