Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not add unnecessary web_accessible_resources from content_scripts #241

Merged
merged 4 commits into from
Dec 30, 2024

Conversation

cezaraugusto
Copy link
Member

Fix #238

@cezaraugusto cezaraugusto self-assigned this Dec 27, 2024
Copy link

pkg-pr-new bot commented Dec 27, 2024

Open in Stackblitz

npm i https://pkg.pr.new/extension-js/extension.js/extension@241
npm i https://pkg.pr.new/extension-js/extension.js/extension-create@241
npm i https://pkg.pr.new/extension-js/extension.js/extension-develop@241

commit: d000040

Copy link

codecov bot commented Dec 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
...ck/plugin-extension/feature-web-resources/index.ts 63.01% <100.00%> (+0.51%) ⬆️

... and 7 files with indirect coverage changes

@cezaraugusto cezaraugusto force-pushed the web_accessible_resources branch from 57e7fda to 926ab2c Compare December 28, 2024 21:16
@cezaraugusto cezaraugusto marked this pull request as ready for review December 28, 2024 22:05
@cezaraugusto cezaraugusto merged commit e858076 into main Dec 30, 2024
15 checks passed
@cezaraugusto cezaraugusto deleted the web_accessible_resources branch December 30, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Including script only content_scripts adds unnecessary web_accessible_resources and breaks build
1 participant