Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

displaCy dependency tree labels backwards (and upside down) in RTL languages in certain browsers #4854

Open
erip opened this issue Dec 30, 2019 · 4 comments
Labels
bug Bugs and behaviour differing from documentation feat / visualizers Feature: Built-in displaCy and other visualizers help wanted Contributions welcome!

Comments

@erip
Copy link
Contributor

erip commented Dec 30, 2019

How to reproduce the behaviour

Reproducing this is difficult without a depencency parse available for an RTL language, but I've included a link to HTML with the errant RTL. The link is here.

Your Environment

Info about spaCy

  • spaCy version: 2.2.3
  • Platform: Darwin-19.2.0-x86_64-i386-64bit
  • Python version: 3.6.7
@erip
Copy link
Contributor Author

erip commented Dec 30, 2019

Err, interestingly the dependency edges are labeled "correctly" in the raw HTML, so this looks like it might be out of scope for spaCy... I'm not sure, though. This is very strange. :-)

@erip erip changed the title displaCy dependency tree labels backwards in RTL languages displaCy dependency tree labels backwards (and upside down) in RTL languages Dec 30, 2019
@erip
Copy link
Contributor Author

erip commented Dec 30, 2019

The labels look fine in Firefox, but not in Chrome or Safari. It looks like side compatibility -- I'll let you all decide if it's something you'd like to keep as an issue.

@adrianeboyd adrianeboyd added feat / visualizers Feature: Built-in displaCy and other visualizers bug Bugs and behaviour differing from documentation labels Dec 31, 2019
@erip erip changed the title displaCy dependency tree labels backwards (and upside down) in RTL languages displaCy dependency tree labels backwards (and upside down) in RTL languages in certain browsers Dec 31, 2019
@ines
Copy link
Member

ines commented Jan 10, 2020

@erip Thanks for getting to the bottom of this – I guess I didn't check the compatibility carefully enough. (I do remember spending a lot of time reading up on RTL support in SVG, so it's kinda annoying I missed this.)

I'll see if we can find a workaround. If nothing else, I wonder if just rotating the path by 180 degrees could work? 🤔

@svlandeg svlandeg added the help wanted Contributions welcome! label Apr 15, 2020
@polm
Copy link
Contributor

polm commented May 24, 2021

For reference, here's a screenshot from Chrome on Linux.

2021-05-24T17-54-31

Given that time has passed and there's been no expansion of support it seems unlikely this will be supported in other browsers...

https://caniuse.com/mdn-svg_elements_textpath_side

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bugs and behaviour differing from documentation feat / visualizers Feature: Built-in displaCy and other visualizers help wanted Contributions welcome!
Projects
None yet
Development

No branches or pull requests

5 participants