Merge pull request #148 from expertasolutions/issue0147

Issue0147

CurrentReleaseNotes.md

@@ -1,25 +1,4 @@
 ## Issues fixes
 
-- ### [Issue0141](https://github.com/expertasolutions/VstsDashboard/issues/141)
-  - Projects selection now set to be store as user perferences in Azure DevOps/Azure DevOps Server
-  - The scope "vso.extension.data_write" as been added to store extension data. Don't forget to Authorize the Extension permissions.
-
-  ![Issue0141-01](_ReleaseNotes/ReleaseAugust2020/Issue0141/Issue0141-01.png)
-
-- ### [Issue0137](https://github.com/expertasolutions/VstsDashboard/issues/137)
-  - "Status Order" filter selection now set to be store as user perferences in Azure DevOps/Azure DevOps Server
-  - In addition to this issue, "With deployment only" & "Show all deployments" filter has been also store into user preferences extension data.
-  - Data Synchronization time has been reduced from 10seconds to 5seconds
-
-- ### [Issue0139](https://github.com/expertasolutions/VstsDashboard/issues/139)
-  - See issues:
-    - [Issue0137](https://github.com/expertasolutions/VstsDashboard/issues/137)
-    - [Issue0141](https://github.com/expertasolutions/VstsDashboard/issues/141)
-
-- ### [Issue0136](https://github.com/expertasolutions/VstsDashboard/issues/136)
-  - Regex Search is activated on these fields
-    1) Build Definition|Pipeline Name
-    2) Build generated name
-    3) Branch name
-
-#### All these issues are part of the milestone [ReleaseAugust2020](https://github.com/expertasolutions/VstsDashboard/milestone/5?closed=1)
+- ### [Issue0147](https://github.com/expertasolutions/VstsDashboard/issues/147)
+  - Fix the regression causes by the release 1.20209.3 where not data where load

README.md

@@ -8,7 +8,7 @@ The intention was to see what's currently happened into the CI/CD pipeline and p
 ## Permissions Authorization
 Don't forget to Authorize the Extension permissions under your Azure DevOps/Server Organization Settings/Extensions/CI/CD Dashboard.
 
-  ![Issue0141-01](_ReleaseNotes/ReleaseAugust2020/Issue0141/Issue0141-01.png)
+  ![Issue0141-01](screenshots/PermissionAuth.png)
 
 
 ## Supported versions

src/ext/Dashboard/dashboard.tsx

@@ -454,26 +454,38 @@ class CICDDashboard extends React.Component<{}, {}> {
 
         // Select Projectlist from the UserPreferences
         let userPreferences = await getUserPreferences(this.extContext, this.hostInfo.name);
-        for(let i=0;i<userPreferences.selectedProjects.length;i++) {
-          let prString = userPreferences.selectedProjects[i]
-          let pr = this.state.projects.find(x=> x.name === prString);
-          if(pr !== undefined) {
-            let idx = this.state.projects.indexOf(pr);
-            this.projectSelection.select(idx);
-          }
-        }
         //
         if(userPreferences !== undefined) {
-          this.showAllBuildDeployment = (userPreferences.showAllDeployment === 0);
-          this.allDeploymentSelection.select(userPreferences.showAllDeployment);
-
-          this.showOnlyBuildWithDeployments = (userPreferences.withDeploymentOnly === 0);
-          this.onlyWithDeploymentSelection.select(userPreferences.withDeploymentOnly);
 
-          this.showErrorsOnSummaryOnTop = (userPreferences.showErrorsOnTop === 0);
-          this.errorsOnSummaryTopSelection.select(userPreferences.showErrorsOnTop);
+          for(let i=0;i<userPreferences.selectedProjects.length;i++) {
+            let prString = userPreferences.selectedProjects[i]
+            let pr = this.state.projects.find(x=> x.name === prString);
+            if(pr !== undefined) {
+              let idx = this.state.projects.indexOf(pr);
+              this.projectSelection.select(idx);
+            }
+          }
 
-          this.lastBuildsDisplaySelection.select(0);
+          if(userPreferences.showAllDeployment !== undefined) {
+            this.showAllBuildDeployment = (userPreferences.showAllDeployment === 0);
+            this.allDeploymentSelection.select(userPreferences.showAllDeployment);
+          } else {
+            this.allDeploymentSelection.select(1);
+          }
+
+          if(userPreferences.withDeploymentOnly !== undefined) {
+            this.showOnlyBuildWithDeployments = (userPreferences.withDeploymentOnly === 0);
+            this.onlyWithDeploymentSelection.select(userPreferences.withDeploymentOnly);
+          } else {
+            this.onlyWithDeploymentSelection.select(1);
+          }
+
+          if(userPreferences.showErrorsOnTop !== undefined) {       
+            this.showErrorsOnSummaryOnTop = (userPreferences.showErrorsOnTop === 0);
+            this.errorsOnSummaryTopSelection.select(userPreferences.showErrorsOnTop);
+          } else {
+            this.errorsOnSummaryTopSelection.select(0);
+          }
         } else {
           this.allDeploymentSelection.select(1);
           this.onlyWithDeploymentSelection.select(1);