-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
activate test tera_templates_are_in_sync in ci #2037
Conversation
as discussed here |
hmm, works on my machine 🤔 |
Works on my machine as well. |
It wasn't active before, because it was thought to be too slow. Turns out it's not that bad.
6728167
to
cc692bb
Compare
26249e6
to
19db560
Compare
bb6f303
to
b2bd329
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@senekor I should have known from the start that it was just problem-specifications missing, but wasn't familiar with github actions and especially this repo's actions. Live and learn I guess.
Unfortunately the first exercise with a template also had additional tests, which had me thinking that only some of the canonical-data tests were being rendered. Of course, it ended up just being additional-tests.json.
Ah, makes sense. For the record, the problem-specifications stuff is one of the things I did I'm not totally happy with. It's not entirely my fault, I think there should be a way to point configlet at a specific version of prolem-specifications (e.g. a submodule), but there isn't. It only wants to work with its own cache. So I bent over backwards to get some kind of reproducibility. I'm open to ideas about how to do that better. I personally also don't need the For next time, I'd prefer if you push your own work to a separate branch instead of mine 🙂 |
It wasn't active before, because it was thought to be too slow. Turns out it's not that bad.