Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

activate test tera_templates_are_in_sync in ci #2037

Merged
merged 7 commits into from
Feb 22, 2025
Merged

Conversation

senekor
Copy link
Contributor

@senekor senekor commented Feb 22, 2025

It wasn't active before, because it was thought to be too slow. Turns out it's not that bad.

@senekor
Copy link
Contributor Author

senekor commented Feb 22, 2025

as discussed here

@senekor
Copy link
Contributor Author

senekor commented Feb 22, 2025

hmm, works on my machine 🤔

@ellnix
Copy link
Contributor

ellnix commented Feb 22, 2025

Works on my machine as well.

It wasn't active before, because it was thought to be too slow. Turns
out it's not that bad.
@senekor senekor force-pushed the senekor/xtwmpyuzlrmz branch from 6728167 to cc692bb Compare February 22, 2025 14:25
@ellnix ellnix force-pushed the senekor/xtwmpyuzlrmz branch from 26249e6 to 19db560 Compare February 22, 2025 17:09
@ellnix ellnix force-pushed the senekor/xtwmpyuzlrmz branch from bb6f303 to b2bd329 Compare February 22, 2025 17:38
This reverts commit 55b7c3a.
This reverts commit 19db560.
This reverts commit 87d83ef.
Copy link
Contributor

@ellnix ellnix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@senekor I should have known from the start that it was just problem-specifications missing, but wasn't familiar with github actions and especially this repo's actions. Live and learn I guess.

Unfortunately the first exercise with a template also had additional tests, which had me thinking that only some of the canonical-data tests were being rendered. Of course, it ended up just being additional-tests.json.

@senekor
Copy link
Contributor Author

senekor commented Feb 22, 2025

Ah, makes sense.

For the record, the problem-specifications stuff is one of the things I did I'm not totally happy with. It's not entirely my fault, I think there should be a way to point configlet at a specific version of prolem-specifications (e.g. a submodule), but there isn't. It only wants to work with its own cache. So I bent over backwards to get some kind of reproducibility.

I'm open to ideas about how to do that better.

I personally also don't need the .prob-spec symlinks anymore that are strewn about all the exercise directories. I used to work with a file tree where these were useful, but now I mostly use a fuzzy file picker. If you don't need them either, we could remove them.

For next time, I'd prefer if you push your own work to a separate branch instead of mine 🙂

@senekor senekor merged commit 3114fb7 into main Feb 22, 2025
10 checks passed
@senekor senekor deleted the senekor/xtwmpyuzlrmz branch February 22, 2025 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants