Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace ensure_stubs_compile with faster rust test #2030

Merged
merged 1 commit into from
Feb 21, 2025

Conversation

senekor
Copy link
Contributor

@senekor senekor commented Feb 20, 2025

part of #1839

@senekor
Copy link
Contributor Author

senekor commented Feb 20, 2025

The Rust test stubs_are_warning_free basically does everything ensure_stubs_compile.sh does, just in parallel (waaay faster). The only differences I found when comparing were:

  • The bash script also checked tests, so I added the --tests flag to the Rust test
  • On PRs, the bash script only runs on the exercises that were changed. Since all exercises are checked in parallel now, I think we can drop that complexity. It's not needed anymore for speed.

@senekor senekor requested a review from ellnix February 20, 2025 21:52
Copy link
Contributor

@ellnix ellnix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read the files multiple times, I don't think anything fell through the cracks. LGTM!

The parallel test in indeed way faster.

@senekor senekor merged commit e777561 into main Feb 21, 2025
12 checks passed
@senekor senekor deleted the senekor/kwommzrtltrl branch February 21, 2025 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants