Starts docs and exercises, implement verify-exercises #3
Conversation
highlightjs does not support Roc, haskell should work ok
|
I addressed all comments, is this good to merge @ErikSchierboom? |
Clarify About.md Co-authored-by: András B Nagy <20251272+BNAndras@users.noreply.github.com>
Co-authored-by: Erik Schierboom <erik_schierboom@hotmail.com>
…-roc into start-docs-and-exercises
Co-authored-by: András B Nagy <20251272+BNAndras@users.noreply.github.com>
|
Thank you all for reviewing this PR. 👍 I think I've addressed all the points you raised. |
|
I'm a bit confused why Github is telling me that there's still 1 change requested by @Anton-4, but it points me to this comment, and there's no "Resolve Conversation" button. |
|
The person requesting changes needs to approve and then you can merge. |
|
Oh of course, thanks. |
|
|
||
| See https://exercism.org/docs/building/tracks/docs for more information. --> | ||
| To install Roc, please follow the instructions at [roc-lang.org/install](https://roc-lang.org/install). | ||
| You only need to install Roc, and optionally the editor Extensions/Plugins of your choice, you don't need to install Rust or Zig (which are used to build Roc itself). |
There was a problem hiding this comment.
Not sure if any student would have expected to install Rust of Zig, that seems more like an implementation detail.
Maybe instead of this:
| You only need to install Roc, and optionally the editor Extensions/Plugins of your choice, you don't need to install Rust or Zig (which are used to build Roc itself). | |
| There are also some [Editor Extensions/Plugins](https://www.roc-lang.org/install#editor-extensions) that you might want to install. |
Or something like that
There was a problem hiding this comment.
Hi @ErikSchierboom ,
I'm sorry I missed your last comments and I merged the PR. I'm happy to create another one to address your comments if you want.
@keiravillekode or @BNAndras suggested above that it might be good to clarify exactly what needs to be installed, since Roc's installation instructions give you several options (including installing Zig or Rust, in case you want to build Roc from source or create some Roc platforms).
There was a problem hiding this comment.
Ah right! Nevermind, forget about my comment then.
|
Sorry for the lengthy review process! That is partially caused by this being the first PR, and by this PR doing a lot of things :) |
Add a first version of each documentation file.
Also add the first two practice exercises, hello-world and leap, including example code and tests.
Lastly, implement
verify-exercises(all tests pass).configlet lintandconfiglet syncare happy. 👍