Add additional tests to clock exercise for extreme I64 values, fixes #150 #155
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds tests that ensure that the implementation can handle the min and max I64 values.
This makes the exercise a bit harder, perhaps we should bump its difficulty to 3.
Another option would be to let the functions return
Result Str _
rather thanStr
, and just ensure that the tests for the min/max I64 values don't crash: we can simply make sure that the result for these test cases are eitherOk
with the correct value, or anyErr
. Wdyt?