Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional tests to clock exercise for extreme I64 values, fixes #150 #155

Merged
merged 2 commits into from
Oct 19, 2024

Conversation

ageron
Copy link
Contributor

@ageron ageron commented Oct 13, 2024

This PR adds tests that ensure that the implementation can handle the min and max I64 values.
This makes the exercise a bit harder, perhaps we should bump its difficulty to 3.

Another option would be to let the functions return Result Str _ rather than Str, and just ensure that the tests for the min/max I64 values don't crash: we can simply make sure that the result for these test cases are either Ok with the correct value, or any Err. Wdyt?

Copy link

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

Copy link
Contributor

@isaacvando isaacvando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving the approach as it is now and bumping it to 3 sounds good to me 👍
If it is possible to reasonably avoid returning a result I always like to do so.

@ageron ageron merged commit d99ef97 into exercism:main Oct 19, 2024
2 checks passed
@ageron ageron deleted the add-clock-tests branch October 19, 2024 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants