Add go-counting exercise #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: I've had to add temporary workarounds for issues roc-lang/roc#7111 and roc-lang/roc#7144 in the
go-counting-test.rocfile, to extract the sets fromresultandexpectedbefore comparing them.Another option would be to return lists instead of sets, but then we would have to sort them before comparing them, which also adds some complexity in the test file. Moreover, I feel like it wouldn't be the proper API for this module (a territory really is a set of intersections, not a list), so we would need to revisit the API later on, once the issues are fixed, and users would get a warning and they would have to update their code.