Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve complex-numbers #102

Merged
merged 4 commits into from
Sep 21, 2024
Merged

Conversation

ageron
Copy link
Contributor

@ageron ageron commented Sep 21, 2024

Oops, I pushed #100 too fast.

This PR improves the complex-numbers exercise:

  • removes the "not-implemented" section in template.j2
  • uses destructuring in the solution to make the equations nicer to read

Copy link

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

Copy link
Contributor

@isaacvando isaacvando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ageron ageron merged commit 33345b3 into exercism:main Sep 21, 2024
4 checks passed
@ageron ageron deleted the improve-complex-numbers branch September 21, 2024 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants