Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TESTS.md #3830

Merged
merged 4 commits into from
Nov 25, 2024
Merged

Update TESTS.md #3830

merged 4 commits into from
Nov 25, 2024

Conversation

glaxxie
Copy link
Contributor

@glaxxie glaxxie commented Nov 24, 2024

  • Change placeholder brackets from {} to <>
  • Add a note explain placeholder value
  • Change pytest version number to reflect the latest one

per discussion from forum here

- Change placeholder brackets from `{}` to `<>`
- Add a note explain placeholder value
- Change pytest version number to reflect the latest one
Small change to fit with the version in `INSTALLATION.md`
Copy link
Member

@BethanyG BethanyG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. Thanks for this, @glaxxie! 🚀

I've made a couple of suggestions, and added verbiage at the end to call out which versions of Python, pytest, and pylint are currently in use on the website. I am tempted to put a warning about versions at the top of the file, but decided that a version mis-match at this point probably won't cause overt issues.

We'll be upgrading to Python 3.12 and the latest versions of pytest and pylint just as soon as I can test and vet everything. But I have been holding off due to various issues and some required fixes across tooling and documentation.

LMK if you have questions/issues/disagreements with my suggestions. 🙂 If not, we can get this merged today. 🎉

docs/TESTS.md Outdated Show resolved Hide resolved
docs/TOOLS.md Outdated Show resolved Hide resolved
glaxxie and others added 2 commits November 25, 2024 13:17
Using exercism note block and clearer example

Co-authored-by: BethanyG <BethanyG@users.noreply.github.com>
Add more details about tooling

Co-authored-by: BethanyG <BethanyG@users.noreply.github.com>
@glaxxie glaxxie requested a review from BethanyG November 25, 2024 19:22
@BethanyG
Copy link
Member

Pushing the big, green button! 🎉

@BethanyG BethanyG merged commit 01fb257 into exercism:main Nov 25, 2024
8 checks passed
@glaxxie glaxxie deleted the testing-docs branch November 25, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants