Update the description for the complex-numbers exercise #2496
Conversation
|
Hello. Thanks for opening a PR on Exercism 🙂 We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in. You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch. If you're interested in learning more about this auto-responder, please read this blog post. Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it. |
|
@jagdish-15 Looks like you might have forgotten to run the linter on this. |
tasxatzial
changed the title
|
@Cool-Katt, apologies for the initial oversight! I’ve updated the file so it now passes all tests. I’m a bit uncertain about the ordered list formatting—I've prefixed each item with “1.” as required by markdownlint, but if there’s a better approach, I'd appreciate any guidance. Thanks! |
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
For those who want to see the rich text in the latest form when reviewing. And here is the split raw view without whitespace changes
|
Thank you so much for the feedback, @SleeplessByte! I'll definitely address the linter issues. If you notice any other areas for improvement or have any suggestions for refining this version further, I’d love to hear them! |
|
I’d also love to know if this change will automatically update in instructions.md across all tracks, or if it’ll require a manual update. |
Each track will need to sync it manually. Some tracks do have tooling to alert the maintainer when there are unsynced changes in the problem specifications repo, but the actual syncing is still done by a human. |
|
It is possible to trigger a PR that updates the description across all tracks with a script. However, it's more likely that track maintainers will perform a batch sync once a month, for example, to pull in all changes from this repo. |
|
Thank you so much, everyone! Before wrapping up, I’d love to know if there’s anything I should keep in mind for next time, or if you’d like any additional changes to the current file. |
Co-authored-by: Anastasios Chatzialexiou <16361161+tasxatzial@users.noreply.github.com>
Co-authored-by: Anastasios Chatzialexiou <16361161+tasxatzial@users.noreply.github.com>
|
Thank you so much, @tasxatzial! I really appreciate all your help. If there’s anything else that might need fixing, I’d love to hear your suggestions. |
Co-authored-by: Anastasios Chatzialexiou <16361161+tasxatzial@users.noreply.github.com>
|
It's done, @tasxatzial! |
|
Now we just need @exercism/maintainers-admin to sign-off. Great work @jagdish-15. |
There was a problem hiding this comment.
@jagdish-15 Final suggestion, this is also for consistency with the previous part that introduces exponentiation
Co-authored-by: Anastasios Chatzialexiou <16361161+tasxatzial@users.noreply.github.com>
|
I believe this addresses both of the issues mentioned above. @tasxatzial, @ErikSchierboom, @IsaacG, @SleeplessByte, @Cool-Katt, and @BNAndras—please let me know if there’s anything else that needs attention. [I've done two more commits after this] |
|
I've updated the description and made several changes to improve clarity and formatting. Could you please review it and let me know if any further adjustments are needed? |
There was a problem hiding this comment.
Looks great.
@jagdish-15 Thanks for your incredible patience and effort!
|
With this commit, I believe the formatting issues are resolved, and this should be ready to merge. Please let me know if I’ve missed anything. A big thank you to @ErikSchierboom, @kotp, @Cool-Katt, @BNAndras, and @SleeplessByte, and especially to @tasxatzial and @IsaacG for reviewing this and providing your valuable feedback! |
Pull Request Description
This pull request updates the description file for the Complex Number exercise, as discussed in the forum thread. The changes reflect the updated description with no objections raised during the discussion.