-
-
Notifications
You must be signed in to change notification settings - Fork 544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check links in toml and json files #2294
Conversation
Really great that you've identified this! |
I see that the elixir track is adding checking of JSON files also. |
What I tried to far: |
I'll just add that server to ignored links. It looks like it's SSL certificate is misconfigured or something. The PR can be reviewed, but it requires #2293 to be merged first to have green CI. |
2ef0370
to
d528360
Compare
I've rebased onto main. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a nice addition, thank you!
All the twitter links are timing out right now. I tried re-running the link checking job, but it's still timing out on the twitter links. Let's try rerunning it later to see if it manages to get through it. |
I forgot about this PR 🤦 All Twitter links are still timing out. I stopped using Twitter a while ago, but I think currently not logged in users are only allowed to see pages for single tweets. They are not allowed to see profile pages for example. I'm not allowed to access https://twitter.com/jeg2. And scripts aren't allow to access anything. I think the only solution is for us to remove all Twitter links from this repo. People cannot access them anyway. Unrelated, the web archive is returning 503s today. I hope that's temporary. |
That is absolutely bonkers, but it is true! 🤦
I agree. We can always restore them if something changes. |
We're adding the same link checker to the Elixir repo to catch dead links (PR) and I noticed it's failing on some URLs that come from this repository, three URLs from
https://users.csc.calpoly.edu
. How could that be? Well, this repository contains exercise metadata in toml files, which contain source URLs, which do not get checked.Adding the check for toml and json files increases the number of links checked from 98 to 212.
This is a draft because I'm not sure yet how to fix those three URLs...I will just ignore them.