Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check links in toml and json files #2294

Merged
merged 7 commits into from
Sep 16, 2023
Merged

Check links in toml and json files #2294

merged 7 commits into from
Sep 16, 2023

Conversation

angelikatyborska
Copy link
Member

@angelikatyborska angelikatyborska commented Jun 22, 2023

We're adding the same link checker to the Elixir repo to catch dead links (PR) and I noticed it's failing on some URLs that come from this repository, three URLs from https://users.csc.calpoly.edu. How could that be? Well, this repository contains exercise metadata in toml files, which contain source URLs, which do not get checked.

Adding the check for toml and json files increases the number of links checked from 98 to 212.

This is a draft because I'm not sure yet how to fix those three URLs... I will just ignore them.

| ✗ [ERR] https://users.csc.calpoly.edu/~jdalbey/103/Projects/ProgrammingPractice.html | Failed: Network error: error:1416F086:SSL routines:tls_process_server_certificate:certificate verify failed:ssl/statem/statem_clnt.c:1921: (unable to get local issuer certificate)
```~

@wolf99
Copy link
Contributor

wolf99 commented Jun 23, 2023

Really great that you've identified this!
If I get time I'll investigate also, but otherwise Iooking forward to other's thoughts on it.

@wolf99
Copy link
Contributor

wolf99 commented Jun 23, 2023

I see that the elixir track is adding checking of JSON files also.
Would it be good to add that here too?

@angelikatyborska angelikatyborska changed the title Check links in toml files Check links in toml and json files Jun 23, 2023
@angelikatyborska
Copy link
Member Author

Yes, absolutely!

What I tried to far: apt update && apt upgrade ca-certificates, but that didn't help :(

@angelikatyborska
Copy link
Member Author

I'll just add that server to ignored links. It looks like it's SSL certificate is misconfigured or something.

The PR can be reviewed, but it requires #2293 to be merged first to have green CI.

@angelikatyborska angelikatyborska marked this pull request as ready for review June 23, 2023 10:02
@angelikatyborska angelikatyborska requested a review from a team as a code owner June 23, 2023 10:02
@BethanyG BethanyG self-requested a review June 23, 2023 14:05
@kytrinyx
Copy link
Member

I've rebased onto main.

Copy link
Member

@kytrinyx kytrinyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice addition, thank you!

@kytrinyx
Copy link
Member

All the twitter links are timing out right now. I tried re-running the link checking job, but it's still timing out on the twitter links. Let's try rerunning it later to see if it manages to get through it.

@angelikatyborska
Copy link
Member Author

I forgot about this PR 🤦

All Twitter links are still timing out. I stopped using Twitter a while ago, but I think currently not logged in users are only allowed to see pages for single tweets. They are not allowed to see profile pages for example. I'm not allowed to access https://twitter.com/jeg2. And scripts aren't allow to access anything. curl -I on a valid tweet URL always returns 403.

I think the only solution is for us to remove all Twitter links from this repo. People cannot access them anyway.

Unrelated, the web archive is returning 503s today. I hope that's temporary.

@ErikSchierboom
Copy link
Member

All Twitter links are still timing out. I stopped using Twitter a while ago, but I think currently not logged in users are only allowed to see pages for single tweets. They are not allowed to see profile pages for example. I'm not allowed to access https://twitter.com/jeg2. And scripts aren't allow to access anything. curl -I on a valid tweet URL always returns 403.

That is absolutely bonkers, but it is true! 🤦

I think the only solution is for us to remove all Twitter links from this repo. People cannot access them anyway.

I agree. We can always restore them if something changes.

@angelikatyborska angelikatyborska merged commit 03220a9 into main Sep 16, 2023
7 checks passed
@angelikatyborska angelikatyborska deleted the check-toml-links branch September 16, 2023 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants